Daniel Erez has posted comments on this change.

Change subject: webadmin: create cluster hangs
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java
Line 114:             return;
Line 115:         }
Line 116:         if (getEntity() == null) {
Line 117:             StopProgress();
Line 118:             return;
can you remove the 'return' or replace it with 'setWindow(null)'?
(to prevent a blank dialog)
Line 119:         }
Line 120:         // Add host action.
Line 121:         UICommand addHostAction = new UICommand("AddHost", this); 
//$NON-NLS-1$
Line 122: 


--
To view, visit http://gerrit.ovirt.org/11507
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97ac6720a8115142bb041a3e6ecec549f75372d9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to