Maor Lipchuk has posted comments on this change.
Change subject: core: Add VDSM missing error messages.
......................................................................
Patch Set 3: (2 inline comments)
@Eduardo This is not related to this fix, this patch is also lying in gerrit
for a long time, after you reviewed it.
The connectStoragePool flow can be discussed in another scope and see how we
can improve it.
For now this fix improves engine condition, and should be merged.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStoragePoolVDSCommand.java
Line 22: @Override
Line 23: protected void ProceedProxyReturnValue() {
Line 24: VdcBllErrors returnStatus =
GetReturnValueFromStatus(getReturnStatus());
Line 25: switch (returnStatus) {
Line 26: case Done:
1) It does not, see how its being dealt at super.ProceedProxyReturnValue()
2) Not related to the fix.
Line 27: case StoragePoolMasterNotFound:
Line 28: case StoragePoolTooManyMasters:
Line 29: case StoragePoolWrongMaster:
Line 30: super.ProceedProxyReturnValue();
Line 30: super.ProceedProxyReturnValue();
Line 31: break;
Line 32: case ReleaseLockFailure:
Line 33: case AcquireHostIdFailure:
Line 34: case ReleaseHostIdFailure:
I don't understand you. I simply followed your instructions in your previous
comment
Line 35: VDSExceptionBase outEx = new
VDSErrorException(String.format("Failed in vdscommand %1$s, error = %2$s",
Line 36: getCommandName(), getReturnStatus().mMessage));
Line 37: InitializeVdsError(returnStatus);
Line 38: getVDSReturnValue().setSucceeded(false);
--
To view, visit http://gerrit.ovirt.org/8958
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8395c75bbba1f66d08bcd9c21fdeacc7f5e6d4f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
