Shireesh Anjal has posted comments on this change. Change subject: gluster: resolve hostname before checking ip in db ......................................................................
Patch Set 3: Sahina, to answer your question "General question- should we work with VdsStatic or Vds objects?" That would depend on the need. In this case, we are just checking whether a given server exists, or are interested in the id and hostname. For both these, VdsStatic is sufficient. I think it would be more efficient also, since the db query will fire on the table vds_static and not on the vds view which joins 6 tables. -- To view, visit http://gerrit.ovirt.org/12021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab25afc5cb0acb5be288c005d1110c1ad0a54b2d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
