Sahina Bose has posted comments on this change. Change subject: engine: Changes in VdsStaticDAO ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) Minor renaming test method comment .................................................... File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsStaticDAOTest.java Line 82: Line 83: /** Line 84: * Ensures all the right VdsStatic instances are returned. Line 85: */ Line 86: @Test Test name can be changed to testGetByHostName Line 87: public void testGetAllForHost() { Line 88: VdsStatic vds = dao.getByHostName(existingVds Line 89: .getHostName()); Line 90: -- To view, visit http://gerrit.ovirt.org/12052 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0075430a97f19238b93da1e199fa73a4584556d6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches