Sandro Bonazzola has posted comments on this change. Change subject: packaging: allow importing ISO domain on setup, exports.d support ......................................................................
Patch Set 5: (2 inline comments) .................................................... File packaging/fedora/setup/common_utils.py Line 1630: Check if the given path is already exported Line 1631: """ Line 1632: if not os.path.exists(exportsFilePath): Line 1633: return False Line 1634: with open(exportsFilePath) as exportsFile: ok, good point. Line 1635: fileContent = exportsFile.readlines() Line 1636: Line 1637: for line in fileContent: Line 1638: if verifyStringFormat(line, "^%s\s+.+" % (path)): .................................................... File packaging/fedora/setup/engine-setup.py Line 1769: utils.copyFile(basedefs.FILE_NFS_SYSCONFIG, "%s/nfs"%(basedefs.DIR_ETC_SYSCONFIG)) Line 1770: Line 1771: # Start services Line 1772: _startNfsServices() Line 1773: controller.CONF["sd_uuid"] = None This code is shared for the two cases: reimporting an existing domain (then no new uuid is needed, everything should be in place) and creating a new domain. The new uuid will be generated only if it doesn't already exist. The new uuid is required by createISODomain. Line 1774: for entry in os.listdir(controller.CONF["NFS_MP"]): Line 1775: path = os.path.join(controller.CONF["NFS_MP"], entry) Line 1776: if os.path.isdir(path): Line 1777: try: -- To view, visit http://gerrit.ovirt.org/11556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a4343f8374e6439b0ee0a14fff233a0d4a0d5a3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
