Vered Volansky has posted comments on this change.

Change subject: core: DiskImage Hierarchy cleanup
......................................................................


Patch Set 4: (2 inline comments)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java
Line 116:         return getImage().isActive();
Line 117:     }
Line 118: 
Line 119:     public void setActive(boolean active) {
Line 120:         getImage().setActive(true == active);
Huhh, silly
Line 121:     }
Line 122: 
Line 123:     @Override
Line 124:     public Date getCreationDate() {


Line 212:         return getImage().getTemplateImageId();
Line 213:     }
Line 214: 
Line 215:     @Override
Line 216:     public void setImageTemplateGuid(Guid guid) {
*I* didn't, but OK.
Line 217:         getImage().setTemplateImageId(guid);
Line 218:     }
Line 219: 
Line 220:     public Guid getParentId() {


--
To view, visit http://gerrit.ovirt.org/12051
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf49ef042266187a6122ae4a667afd16d80efa52
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to