Allon Mureinik has posted comments on this change.
Change subject: engine: Improving EventQueueMonitor for RecoverySroragePool
scenario
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
The logic looks OK to me, but consider the following improvement:
during reconstruct:
if the new event isn't connect - skip it (like you did)
if the new event is connect:
if there isn't a connect event (for that pool) in the queue - add if
if there already is a connect event (for that pool) - skip it, no reason to
have two consecutive connect event
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/eventqueue/EventQueueMonitor.java
Line 72: case RECOVERY:
Line 73: if (event.getEventType() ==
EventType.VDSCONNECTTOPOOL) {
Line 74: task = addTaskToQueue(event, callable,
storagePoolId, isEventShouldBeFirst(event));
Line 75: } else {
Line 76: log.debugFormat("Current event was skiped
because of recovery is running now for pool {0}, event {1}",
Please fix message:
The current event was skipped because recovery is currently running
for pool {0}, event: {1}
Line 77: storagePoolId, event);
Line 78: }
Line 79: break;
Line 80: case RECONSTRUCT:
--
To view, visit http://gerrit.ovirt.org/11869
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I06f1065db0dd017d1db5ea1dcbd5e8c983a6c46b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
