Maor Lipchuk has posted comments on this change.
Change subject: core: Rename storage_domains entity to StorageDomain
......................................................................
Patch Set 3: (6 inline comments)
Please import org.ovirt.engine.core.common.businessentities in the relevant
classes instead using the full package name.
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendActionableResource.java
Line 244: }
Line 245:
Line 246: protected Guid lookupStorageDomainIdByName(String name) {
Line 247: if (!isFiltered()) {
Line 248: return
getEntity(org.ovirt.engine.core.common.businessentities.StorageDomain.class,
SearchType.StorageDomain, "Storage: name=" + name).getId();
Why not importing org.ovirt.engine.core.common.businessentities
Line 249: }
Line 250: else {
Line 251:
List<org.ovirt.engine.core.common.businessentities.StorageDomain>
storageDomains =
Line 252:
getBackendCollection(org.ovirt.engine.core.common.businessentities.StorageDomain.class,
Line 247: if (!isFiltered()) {
Line 248: return
getEntity(org.ovirt.engine.core.common.businessentities.StorageDomain.class,
SearchType.StorageDomain, "Storage: name=" + name).getId();
Line 249: }
Line 250: else {
Line 251:
List<org.ovirt.engine.core.common.businessentities.StorageDomain>
storageDomains =
Same here
Line 252:
getBackendCollection(org.ovirt.engine.core.common.businessentities.StorageDomain.class,
Line 253: VdcQueryType.GetAllStorageDomains,
Line 254: new VdcQueryParametersBase());
Line 255: for
(org.ovirt.engine.core.common.businessentities.StorageDomain storageDomain :
storageDomains) {
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendStorageDomainContentsResource.java
Line 45: }
Line 46: }
Line 47:
Line 48: protected Guid lookupStorageDomainIdByName(String name) {
Line 49: return
getEntity(org.ovirt.engine.core.common.businessentities.StorageDomain.class,
SearchType.StorageDomain, "Storage: name=" + name).getId();
Why not importing org.ovirt.engine.core.common.businessentities.
Line 50: }
Line 51:
Line 52: public Guid getDataCenterId(Guid storageDomainId) {
Line 53: List<storage_pool> storagepools =
getStoragePools(storageDomainId, this);
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java
Line 415: summary.getUsers().setTotal(get(stats, "total_users"));
Line 416: summary.getUsers().setActive(get(stats, "active_users"));
Line 417:
Line 418: summary.setStorageDomains(new StorageDomains());
Line 419: summary.getStorageDomains().setTotal(get(stats,
"total_org.ovirt.engine.core.common.businessentities.StorageDomain"));
Why using the full package name?
Line 420: summary.getStorageDomains().setActive(get(stats,
"active_org.ovirt.engine.core.common.businessentities.StorageDomain"));
Line 421:
Line 422: api.setSummary(summary);
Line 423: }
Line 416: summary.getUsers().setActive(get(stats, "active_users"));
Line 417:
Line 418: summary.setStorageDomains(new StorageDomains());
Line 419: summary.getStorageDomains().setTotal(get(stats,
"total_org.ovirt.engine.core.common.businessentities.StorageDomain"));
Line 420: summary.getStorageDomains().setActive(get(stats,
"active_org.ovirt.engine.core.common.businessentities.StorageDomain"));
same here
Line 421:
Line 422: api.setSummary(summary);
Line 423: }
Line 424: return api;
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAttachedStorageDomainResource.java
Line 14: import org.ovirt.engine.core.common.queries.VdcQueryType;
Line 15: import org.ovirt.engine.core.compat.Guid;
Line 16:
Line 17: public class BackendAttachedStorageDomainResource
Line 18: extends AbstractBackendActionableResource<StorageDomain,
org.ovirt.engine.core.common.businessentities.StorageDomain>
please import org.ovirt.engine.core.common.businessentities
Line 19: implements AttachedStorageDomainResource {
Line 20:
Line 21: protected Guid dataCenterId;
Line 22:
--
To view, visit http://gerrit.ovirt.org/11782
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id87b0d8f4896c84b7a40863cc86a9ef8219627d0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
