Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Show data centers and their clusters based on
configured cluster service
......................................................................
Patch Set 3: (4 inline comments)
should be user query (although I'm not sure we use it in userportal)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
Line 239: GetAllStorageDomains(VdcQueryAuthType.User),
Line 240: GetExistingStorageDomainList,
Line 241: GetStorageDomainByIdAndStoragePoolId,
Line 242: GetStoragePoolsByStorageDomainId,
Line 243: GetStoragePoolsByClusterService,
user query?
Line 244: GetStorageDomainListById,
Line 245: GetLunsByVgId,
Line 246: GetPermittedStorageDomainsByStoragePoolId(VdcQueryAuthType.User),
Line 247: GetPermittedStorageDomainsByTemplateId(VdcQueryAuthType.User),
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
Line 370: new SearchParameters("DataCenter: sortby name",
SearchType.StoragePool), //$NON-NLS-1$
Line 371: aQuery);
Line 372: }
Line 373:
Line 374: public static void GetDataCenterByClusterServiceList(AsyncQuery
aQuery, boolean supportsVirtService, boolean supportsGlusterService) {
GetDataCenterByClusterServiceList ->
GetDataCentersByClusterService or GetDataCenterListByClusterService
Line 375: aQuery.converterCallback = new IAsyncConverter() {
Line 376: @Override
Line 377: public Object Convert(Object source, AsyncQuery
_asyncQuery) {
Line 378: if (source == null) {
Line 585: new StoragePoolQueryParametersBase(dataCenterId),
Line 586: aQuery);
Line 587: }
Line 588:
Line 589: public static void GetClusterByServiceList(AsyncQuery aQuery,
Guid dataCenterId,
same.
Line 590: final boolean supportsVirtService, final boolean
supportsGlusterService) {
Line 591: aQuery.converterCallback = new IAsyncConverter() {
Line 592: @Override
Line 593: public Object Convert(Object source, AsyncQuery
_asyncQuery) {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
Line 1228: }
Line 1229:
Line 1230: public final static class StorageNamePredicate implements
IPredicate<storage_domains> {
Line 1231:
Line 1232: private final String name;
remove final
Line 1233:
Line 1234: public StorageNamePredicate(String name) {
Line 1235: this.name = name;
Line 1236: }
--
To view, visit http://gerrit.ovirt.org/11395
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb63c7e2addf525bb527d94694a8dfc752d69154
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <lspe...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Libor Spevak <lspe...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
