[Engine-patches] Change in ovirt-engine[master]: webadmin: remove hide popup feature.

[awels]

Alexander Wels has uploaded a new change for review.

Change subject: webadmin: remove hide popup feature.
......................................................................

webadmin: remove hide popup feature.

- Removed feature to hide error popups when logging out as
they are no longer needed

Change-Id: I2fc7ee921159aafc7e9c85cd2093b7882fcfe3b4
Signed-off-by: Alexander Wels <aw...@redhat.com>
---
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ErrorPopupManager.java
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/presenter/LoginSectionPresenter.java
2 files changed, 2 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/23/12023/1

diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ErrorPopupManager.java
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ErrorPopupManager.java
index 085257c..6ca1427 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ErrorPopupManager.java
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ErrorPopupManager.java
@@ -16,17 +16,10 @@
     private final EventBus eventBus;
     private final ErrorPopupPresenterWidget errorPopup;
 
-    private boolean showPopups;
-
     @Inject
     public ErrorPopupManager(EventBus eventBus, ErrorPopupPresenterWidget 
errorPopup) {
         this.eventBus = eventBus;
         this.errorPopup = errorPopup;
-        this.showPopups = true;
-    }
-
-    public void setShowPopups(boolean showPopups) {
-        this.showPopups = showPopups;
     }
 
     @Override
@@ -35,10 +28,8 @@
     }
 
     public void show(String errorMessage) {
-        if (showPopups) {
-            errorPopup.prepare(errorMessage);
-            RevealRootPopupContentEvent.fire(this, errorPopup);
-        }
+        errorPopup.prepare(errorMessage);
+        RevealRootPopupContentEvent.fire(this, errorPopup);
     }
 
     public void hide(){
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/presenter/LoginSectionPresenter.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/presenter/LoginSectionPresenter.java
index 4b7d1c9..6167adb 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/presenter/LoginSectionPresenter.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/presenter/LoginSectionPresenter.java
@@ -49,22 +49,6 @@
     }
 
     @Override
-    protected void onReveal() {
-        super.onReveal();
-
-        // Disable error popups when entering login section
-        errorPopupManager.setShowPopups(false);
-    }
-
-    @Override
-    protected void onHide() {
-        super.onHide();
-
-        // Enable error popups when leaving login section
-        errorPopupManager.setShowPopups(true);
-    }
-
-    @Override
     protected void onReset() {
         super.onReset();
 


--
To view, visit http://gerrit.ovirt.org/12023
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2fc7ee921159aafc7e9c85cd2093b7882fcfe3b4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches