Michael Pasternak has posted comments on this change. Change subject: restapi : Add /networks sub-collection under /datacenters/xxx(#741111) ......................................................................
Patch Set 2: Do not submit (1 inline comment) nack'ing based on [1]. [1] https://bugzilla.redhat.com/show_bug.cgi?id=741111#c6 .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java Line 43: GetVdsInterfacesByVdsId(VdcQueryAuthType.User), Line 44: GetVdsFreeBondsByVdsId, Line 45: GetAllNetworks(VdcQueryAuthType.User), Line 46: GetAllNetworksByClusterId(VdcQueryAuthType.User), Line 47: GetNetworksByStoragePoolId(VdcQueryAuthType.User), not sure it's should be a public query, yair? Line 48: GetNonOperationalVds, Line 49: GetManagementInterfaceAddressByVmId(VdcQueryAuthType.User), Line 50: // Vm Network Line 51: GetVmInterfacesByVmId(VdcQueryAuthType.User), -- To view, visit http://gerrit.ovirt.org/11707 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacc4a480e3a1270cfcab022549e7f53cfc352c6e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
