Kanagaraj M has posted comments on this change.

Change subject: webadmin: using search backend to find Up server in cluster
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
Line 1864:             }
Line 1865:         };
Line 1866:         GetUpHostListByCluster(aQuery, clusterName, null);
Line 1867:     }
Line 1868: 
I feel this can stay as public, as this can be used by anyone directly.
Line 1869:     public static void GetUpHostListByCluster(AsyncQuery aQuery, 
String clusterName, Integer maxCount) {
Line 1870:         SearchParameters searchParameters =
Line 1871:                 new SearchParameters("Host: cluster = " + 
clusterName + " and status = up", SearchType.VDS); //$NON-NLS-1$ //$NON-NLS-2$
Line 1872:         if (maxCount != null) {


--
To view, visit http://gerrit.ovirt.org/11995
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2ba449d2fa43d0c2e510ec4d0b51d3dc359b6ae
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to