Michael Kublin has posted comments on this change.
Change subject: core: TimeoutBase: Prevent updating mutable Date
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
Line 870: ?
Line 871: Math.max(auditLogable.getEventFloodInSec(), 30) //
Min duration for External Events is 30 sec
Line 872: :
Line 873: logType.getDuplicateEventsIntervalValue();
Line 874: if (duplicateEventsIntrvalValue > 0) {
Comment regards millis is correct, but there are much more bigger problem:
the line 875 should be like :
auditLogable.setEndTime(System.currentTimeMillis() +
TimeUnit.SECONDS.toMillis(duplicateEventsIntrvalValue)
because of now we are using logType.getDuplicateEventsIntervalValue()
so for my opinion it is wrong. I think you can fix in this patch or send a new
one, I don't care
Line 875: auditLogable.setEndTime(System.currentTimeMillis() +
logType.getDuplicateEventsIntervalValue());
Line 876:
auditLogable.setTimeoutObjectId(composeObjectId(auditLogable, logType));
Line 877: }
Line 878: }
--
To view, visit http://gerrit.ovirt.org/11897
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd77e518369fa25bfe684d249d12e0f8e2bb1a0f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
