Liron Aravot has posted comments on this change.
Change subject: core: fix redundant storage server conn in db
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionCommand.java
Line 13: super(parameters);
Line 14: }
Line 15:
Line 16: @Override
Line 17: protected void executeCommand() {
I don't understand something - now we will perform the this command for one
host and then the connection will be removed from db, how we will perform the
disconnect for other hosts? the load of connection will return null..no? you
should take care of that i guess.
Line 18: //disconnect the connection from vdsm
Line 19: boolean isStorageDisconnectSucceeded = disconnectStorage();
Line 20:
Line 21: if(isStorageDisconnectSucceeded) {
--
To view, visit http://gerrit.ovirt.org/11936
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea5468371514bd2c7bc043a6c5520e2864a09fe8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
