Moti Asayag has posted comments on this change.

Change subject: core: When updating entity name the event...
......................................................................


Patch Set 5: (2 inline comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 544:     }
Line 545: 
Line 546:     private void logRenamedEntity() {
Line 547:         try {
Line 548:             if (this instanceof RenamedEntityInfoProvider) {
please merge these variable declaration with the initialization.
Line 549:                 String oldEntityName;
Line 550:                 String newEntityName;
Line 551:                 RenamedEntityInfoProvider renameable = 
(RenamedEntityInfoProvider) this;
Line 552:                 String entityType = renameable.getEntityType();


....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
Line 710:     }
Line 711: 
Line 712:     private static void initCommonSeverities() {
Line 713:         severities.put(AuditLogType.ENTITY_RENAMED, 
AuditLogSeverity.NORMAL);
Line 714:     }
please add new line after this method.
Line 715:     private static void initDwhSeverities() {
Line 716:         severities.put(AuditLogType.DWH_STOPPED, 
AuditLogSeverity.NORMAL);
Line 717:         severities.put(AuditLogType.DWH_STARTED, 
AuditLogSeverity.NORMAL);
Line 718:         severities.put(AuditLogType.DWH_ERROR, 
AuditLogSeverity.ERROR);


--
To view, visit http://gerrit.ovirt.org/11756
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17f0049ca0ffb1a3868ba404b112a8c10ee7778e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to