Eli Mesika has posted comments on this change.
Change subject: core:Cannot add external event if flood rate is...
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/EventMapper.java
Line 125: }
Line 126: if (event.isSetOrigin()) {
Line 127: auditLog.setOrigin(event.getOrigin());
Line 128: }
Line 129: auditLog.setCustomEventId(event.getCustomId());
first of all custom_event_id is mandatory so I should not check if it was set
since it must be set
secondly, what is the problem to call a set(int i) with an Integer , it will
do automatically out-boxing and this is working now without any problems
Line 130: if (event.isSetFloodRate()) {
Line 131: auditLog.setEventFloodInSec(event.getFloodRate());
Line 132: }
Line 133: if (event.isSetCustomData()) {
--
To view, visit http://gerrit.ovirt.org/11847
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73a028199bf49a08be5df6f9a72b4cb12fbd1343
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
