Alissa Bonas has posted comments on this change.
Change subject: core: fix redundant storage server conn in db
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectStorageServerConnectionCommand.java
Line 10: import org.ovirt.engine.core.common.vdscommands.VDSCommandType;
Line 11: import org.ovirt.engine.core.dal.VdcBllMessages;
Line 12: import org.ovirt.engine.core.dal.dbbroker.DbFacade;
Line 13:
Line 14: @InternalCommandAttribute
It's called from StorageHelperBase.
And this attribute has been here before the patch, hence not part of the
discussed change.
Line 15: public class DisconnectStorageServerConnectionCommand<T extends
StorageServerConnectionParametersBase> extends
Line 16: StorageServerConnectionCommandBase<T> {
Line 17: public DisconnectStorageServerConnectionCommand(T parameters) {
Line 18: super(parameters);
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
Line 698: }
Line 699: }
Line 700:
Line 701: private void CleanConnection(StorageServerConnections connection,
Guid hostId) {
Line 702:
Frontend.RunAction(VdcActionType.RemoveStorageServerConnection, new
StorageServerConnectionParametersBase(connection, hostId),
Generally speaking, you are probably right and UI should not call internal
commands.
However, the current state of things - before the patch as well, is that UI is
indeed calling internal commands.
The patch is not here to solve this issue, it is solving another bug.
Please note , that DisconnectStorageServerConnectionCommand that its calls are
replaced in several places by this patch and is called from the UI, is also an
internal command.
Line 703: null, this);
Line 704: }
Line 705:
Line 706: private void remove()
--
To view, visit http://gerrit.ovirt.org/11936
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea5468371514bd2c7bc043a6c5520e2864a09fe8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
