Liron Aravot has uploaded a new change for review.

Change subject: core : attach storage domain should attempt to activate
......................................................................

core : attach storage domain should attempt to activate

When attaching storage domain to pool, attemp to activate it after
attaching.

Change-Id: I4e6f21b350520aef47be0ba282a3074a3b3c5119
Signed-off-by: Liron Aravot <lara...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java
M 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java
2 files changed, 11 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/28/11928/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java
index 3c90950..3d3b808 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java
@@ -2,6 +2,7 @@
 
 import java.util.Arrays;
 
+import org.ovirt.engine.core.bll.Backend;
 import org.ovirt.engine.core.bll.NonTransactiveCommandAttribute;
 import org.ovirt.engine.core.bll.context.CommandContext;
 import org.ovirt.engine.core.common.AuditLogType;
@@ -106,6 +107,7 @@
                             return null;
                         }
                     });
+                    attemptToActivateDomain();
                     setSucceeded(true);
                 }
             }
@@ -113,6 +115,13 @@
 
     }
 
+    protected void attemptToActivateDomain() {
+        StorageDomainPoolParametersBase activateParameters = new 
StorageDomainPoolParametersBase(getStorageDomain().getId(),
+                getStoragePool().getId());
+        Backend.getInstance()
+                .runInternalAction(VdcActionType.ActivateStorageDomain, 
activateParameters);
+    }
+
     @Override
     public AuditLogType getAuditLogTypeValue() {
         return getSucceeded() ? AuditLogType.USER_ATTACH_STORAGE_DOMAIN_TO_POOL
diff --git 
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java
 
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java
index 41a10c2..c5c0095 100644
--- 
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java
+++ 
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java
@@ -5,6 +5,7 @@
 import static org.mockito.Matchers.any;
 import static org.mockito.Mockito.doAnswer;
 import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.doNothing;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.spy;
 import static org.mockito.Mockito.when;
@@ -79,6 +80,7 @@
                 spy(new 
AttachStorageDomainToPoolCommand<StorageDomainPoolParametersBase>(params));
 
         doReturn(dbFacade).when(cmd).getDbFacade();
+        doNothing().when(cmd).attemptToActivateDomain();
 
         when(dbFacade.getStoragePoolIsoMapDao()).thenReturn(isoMapDAO);
         when(dbFacade.getStoragePoolDao()).thenReturn(storagePoolDAO);


--
To view, visit http://gerrit.ovirt.org/11928
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e6f21b350520aef47be0ba282a3074a3b3c5119
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to