Daniel Erez has submitted this change and it was merged. Change subject: webadmin: making RegexValidation testable ......................................................................
webadmin: making RegexValidation testable This patch change the call to Regex#IsMatch(String,String,RegexOptions) within RegexValidation with a call to Regex#IsMatch(String,String). The problem is that Regex#IsMatch(String,String,RegexOptions) isn't implmenented (throws NotImplementedException) in Regex class that is located in compat project, thus classes that inherits RegexValidation can't be tested with unit tests. >From the UI perspective this patch doesn't change much because in the Regex class of the UI (located in gwt-extension) the method Regex#IsMatch(String,String) calls Regex#IsMatch(String,String,RegexOptions) with RegexOptions.None. Change-Id: Ib35b0b1a4b7a29902a65986e1ceadf231a9a8c50 Signed-off-by: Arik Hadas <aha...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/RegexValidation.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11843 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib35b0b1a4b7a29902a65986e1ceadf231a9a8c50 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
