Mike Kolesnik has posted comments on this change. Change subject: core: Logging configuration for dal tests ......................................................................
Patch Set 1: (3 inline comments) .................................................... File backend/manager/modules/dal/src/test/resources/log4j.xml Line 8: <!-- Append messages to the console --> Line 9: <!-- ============================== --> Line 10: Line 11: <appender name="CONSOLE" class="org.apache.log4j.ConsoleAppender"> Line 12: <errorHandler class="org.jboss.logging.util.OnlyOnceErrorHandler"/> Is this a good idea to use jboss specific logging classes here? Line 13: <param name="Target" value="System.out"/> Line 14: <param name="Threshold" value="INFO"/> Line 15: Line 16: <layout class="org.apache.log4j.PatternLayout"> Line 48: <!-- ======================= --> Line 49: Line 50: <!--TOP configuration for all oVirt categories --> Line 51: <category name="org.ovirt.engine.core" additivity="false"> Line 52: <priority value="INFO"/> Please use spaces Line 53: </category> Line 54: Line 55: <category name="org.ovirt.engine.core.utils.ejb.EJBUtilsStrategy" > Line 56: <priority value="ERROR"/> Line 52: <priority value="INFO"/> Line 53: </category> Line 54: Line 55: <category name="org.ovirt.engine.core.utils.ejb.EJBUtilsStrategy" > Line 56: <priority value="ERROR"/> Same here Line 57: </category> Line 58: Line 59: <!--Postgres causes lots of verboe messages in INFO level: Line 60: "Added default SqlReturnResultSet parameter named #result-set-1"--> -- To view, visit http://gerrit.ovirt.org/11896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1862bd1aa4a936fceaf79f5419e8b4ae079cd601 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
