[Engine-patches] Change in ovirt-engine[master]: core: Fix modifiers in VmGuestAgentInterfaceDao

[amureini]

Allon Mureinik has uploaded a new change for review.

Change subject: core: Fix modifiers in VmGuestAgentInterfaceDao
......................................................................

core: Fix modifiers in VmGuestAgentInterfaceDao

Added missing implied final and static modifiers and @Override
annotations in VmGuestAgentInterfaceDaoDbFacadeImpl, to resolve the
MS_SHOULD_BE_FINAL issue detected by FindBugs.

Change-Id: I3b28efa59756f3f022271b8d8e352ceb3c91887d
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmGuestAgentInterfaceDaoDbFacadeImpl.java
1 file changed, 6 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/98/11898/1

diff --git 
a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmGuestAgentInterfaceDaoDbFacadeImpl.java
 
b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmGuestAgentInterfaceDaoDbFacadeImpl.java
index 7dd3f0e..5cc7a29 100644
--- 
a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmGuestAgentInterfaceDaoDbFacadeImpl.java
+++ 
b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmGuestAgentInterfaceDaoDbFacadeImpl.java
@@ -15,6 +15,7 @@
 
     private static final String DELIMITER = ",";
 
+    @Override
     public List<VmGuestAgentInterface> getAllForVm(Guid vmId) {
         return getAllForVm(vmId, null, false);
     }
@@ -28,11 +29,13 @@
                         .addValue("filtered", filtered));
     }
 
+    @Override
     public void save(VmGuestAgentInterface vmGuestAgentInterface) {
         getCallsHandler().executeModification("InsertVmGuestAgentInterface",
                 createFullParametersMapper(vmGuestAgentInterface));
     }
 
+    @Override
     public void removeAllForVm(Guid vmId) {
         
getCallsHandler().executeModification("DeleteVmGuestAgentInterfacesByVmId",
                 getCustomMapSqlParameterSource().addValue("vm_id", vmId));
@@ -47,12 +50,12 @@
                 .addValue("ipv6_addresses", 
getIpAddressesAsString(entity.getIpv6Addresses()));
     }
 
-    private String getIpAddressesAsString(List<String> ipAddresses) {
+    private static String getIpAddressesAsString(List<String> ipAddresses) {
         return StringUtils.join(ipAddresses, DELIMITER);
     }
 
     protected final static class VmGuestAgentInterfaceRowMapper implements 
ParameterizedRowMapper<VmGuestAgentInterface> {
-        public static VmGuestAgentInterfaceRowMapper instance = new 
VmGuestAgentInterfaceRowMapper();
+        public static final VmGuestAgentInterfaceRowMapper instance = new 
VmGuestAgentInterfaceRowMapper();
 
         @Override
         public VmGuestAgentInterface mapRow(ResultSet rs, int rowNum)
@@ -66,7 +69,7 @@
             return vmGuestAgentInterface;
         }
 
-        private List<String> getListOfIpAddresses(String ipAddressesAsString) {
+        private static List<String> getListOfIpAddresses(String 
ipAddressesAsString) {
             return ipAddressesAsString == null ? null
                     : Arrays.asList(StringUtils.split(ipAddressesAsString, 
DELIMITER));
         }


--
To view, visit http://gerrit.ovirt.org/11898
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b28efa59756f3f022271b8d8e352ceb3c91887d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches