Maor Lipchuk has posted comments on this change.
Change subject: engine: cleanup Vds
......................................................................
Patch Set 4: (1 inline comment)
@Lazlo - Regarding the deleted command, you should use git grep on RemoveBond
instead RemoveBondCommand, since we are using reflection for vdc commands.
The RemoveBond is used in BackendHostNicsResource at the rest side.
(BTW, not related to this patch, but it crossed my mind to add a test for that
in the future, or at least I will send a patch for orphaned commands and enums
if I will find any)
Looks very good, See one comment inside.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java
Line 42: mUpdateVdsStatic.AddPermittedField("pmType");
Line 43: mUpdateVdsStatic.AddPermittedField("pmUser");
Line 44: mUpdateVdsStatic.AddPermittedField("pmPassword");
Line 45: mUpdateVdsStatic.AddPermittedField("pmPort");
Line 46: mUpdateVdsStatic.AddPermittedField("pmPptions");
s/pmPption/pmOptions
Line 47: mUpdateVdsStatic.AddPermittedField("pmEnabled");
Line 48: mUpdateVdsStatic.AddPermittedField("pmProxyPreferences");
Line 49: mUpdateVdsStatic.AddPermittedField("PmOptionsMap");
Line 50: mUpdateVdsStatic.AddPermittedField("managmentIp");
--
To view, visit http://gerrit.ovirt.org/11351
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11ca149d6fe3f66ed1357f447bbd6c27d73dbe4d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
