Allon Mureinik has posted comments on this change. Change subject: core: Moved ui event related classes from compat ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) +1 on the patch, -1 on the commit message (see inline), +300 on reordering the inputs. Now, seriously: - The patch looks fine from a backend standpoint, please get a +2 from one of the frontend maintianers. - When you rebase, please fix the commit message as Alissa suggested. .................................................... Commit Message Line 5: CommitDate: 2013-02-06 17:05:42 +0200 Line 6: Line 7: core: Moved ui event related classes from compat Line 8: Line 9: Removed the ui event related classes that existed in the compat module s/Removed/Moved/ Line 10: to uicompat where they belonged, they were originally put in compat for Line 11: legacy reasons that are not relevant anymore. Line 12: Line 13: Change-Id: I0861b240d3fce585b13d507bfa24d0e1844a721f -- To view, visit http://gerrit.ovirt.org/11806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0861b240d3fce585b13d507bfa24d0e1844a721f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
