Omer Frenkel has posted comments on this change.
Change subject: webdmin: Restrict destination host parameter for administrator
only
......................................................................
Patch Set 3: (1 inline comment)
looks good, thanks! minor comment inside i just noticed
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 866: }
Line 867:
Line 868: // check, if user can override default target host for VM
Line 869: final Guid destinationVdsId =
getParameters().getDestinationVdsId();
Line 870: if (destinationVdsId != null &&
!destinationVdsId.equals(getVm().getDedicatedVmForVds())) {
please check that getVm() != null, since this code runs before canDoAction we
cannot assume vm sent from user does exist
Line 871: permissionList.add(new
PermissionSubject(getParameters().getVmId(),
Line 872: VdcObjectType.VM,
Line 873: ActionGroup.EDIT_VM_PROPERTIES));
Line 874: }
--
To view, visit http://gerrit.ovirt.org/11303
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5294854d24b235f2c50fa7f3d4e7472cf7598b53
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Libor Spevak <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
