Daniel Erez has uploaded a new change for review.
Change subject: core: MoveDisksCommands - disk id for perm subject
......................................................................
core: MoveDisksCommands - disk id for perm subject
Passing diskId instead of imageId for permission subject.
Change-Id: I87d7733174b7b5af805f53834c64e032aafbe94b
Signed-off-by: Daniel Erez <de...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/38/11838/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java
index 12ca472..2a49a1a 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java
@@ -163,9 +163,12 @@
List<PermissionSubject> permissionList = new
ArrayList<PermissionSubject>();
for (MoveOrCopyImageGroupParameters parameters :
getParameters().getParametersList()) {
- permissionList.add(new PermissionSubject(parameters.getImageId(),
- VdcObjectType.Disk,
- ActionGroup.CONFIGURE_DISK_STORAGE));
+ DiskImage diskImage =
getDiskImageDao().get(parameters.getImageId());
+ if (diskImage != null) {
+ permissionList.add(new PermissionSubject(diskImage.getId(),
+ VdcObjectType.Disk,
+ ActionGroup.CONFIGURE_DISK_STORAGE));
+ }
}
return permissionList;
--
To view, visit http://gerrit.ovirt.org/11838
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I87d7733174b7b5af805f53834c64e032aafbe94b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
