Mike Kolesnik has uploaded a new change for review.
Change subject: engine: Added NetworkHelper class
......................................................................
engine: Added NetworkHelper class
This class will hold static methods relating to the Network entity, such
as determining if it's a management network.
Change-Id: I27844da800326e338ec193b4ffd1fb2ee6aef034
Signed-off-by: Mike Kolesnik <mkole...@redhat.com>
---
A
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkHelper.java
A
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/NetworkHelperTest.java
2 files changed, 66 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/35/11835/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkHelper.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkHelper.java
new file mode 100644
index 0000000..e226b1b
--- /dev/null
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkHelper.java
@@ -0,0 +1,23 @@
+package org.ovirt.engine.core.bll.network;
+
+import org.apache.commons.lang.StringUtils;
+import org.ovirt.engine.core.common.businessentities.network.Network;
+import org.ovirt.engine.core.common.config.Config;
+import org.ovirt.engine.core.common.config.ConfigValues;
+
+/**
+ * Class to hold common static methods for {@link Network} that are used in
several different places.
+ */
+public class NetworkHelper {
+
+ /**
+ * Determine if the network is management network.
+ *
+ * @param net
+ * The network to check.
+ * @return <code>true</code> iff the network is a management network.
+ */
+ public static boolean managementNetwork(Network net) {
+ return StringUtils.equals(net.getName(), Config.<String>
GetValue(ConfigValues.ManagementNetwork));
+ }
+}
diff --git
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/NetworkHelperTest.java
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/NetworkHelperTest.java
new file mode 100644
index 0000000..71f9139
--- /dev/null
+++
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/NetworkHelperTest.java
@@ -0,0 +1,43 @@
+package org.ovirt.engine.core.bll.network;
+
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
+import org.junit.Rule;
+import org.junit.Test;
+import org.ovirt.engine.core.common.businessentities.network.Network;
+import org.ovirt.engine.core.common.config.ConfigValues;
+import org.ovirt.engine.core.utils.MockConfigRule;
+import org.ovirt.engine.core.utils.RandomUtils;
+
+public class NetworkHelperTest {
+
+ private static final String MANAGEMENT_NETWORK =
RandomUtils.instance().nextString(
+ RandomUtils.instance().nextInt(1, 10));
+ @Rule
+ public MockConfigRule mcr = new MockConfigRule(
+ MockConfigRule.mockConfig(ConfigValues.ManagementNetwork,
MANAGEMENT_NETWORK));
+
+ @Test
+ public void managementNetwork() throws Exception {
+ Network net = new Network();
+ net.setName(MANAGEMENT_NETWORK);
+
+ assertTrue(NetworkHelper.managementNetwork(net));
+ }
+
+ @Test
+ public void notManagementNetwork() throws Exception {
+ Network net = new Network();
+ net.setName(MANAGEMENT_NETWORK + "1");
+
+ assertFalse(NetworkHelper.managementNetwork(net));
+ }
+
+ @Test
+ public void nullNotManagementNetwork() throws Exception {
+ Network net = new Network();
+
+ assertFalse(NetworkHelper.managementNetwork(net));
+ }
+}
--
To view, visit http://gerrit.ovirt.org/11835
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I27844da800326e338ec193b4ffd1fb2ee6aef034
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
