Daniel Erez has posted comments on this change. Change subject: core: remove disks perms on storage domain destroy ......................................................................
Patch Set 2: (2 inline comments) .................................................... File backend/manager/dbscripts/storages_sp.sql Line 587: JOIN vm_device ON vm_device.device_id = vm_images_view.disk_id Line 588: where v_storage_domain_id in (SELECT * FROM fnsplitteruuid(storage_id)) and vm_images_view.entity_type <> 'TEMPLATE'); Line 589: delete FROM snapshots WHERE vm_id in (select vm_id as vm_guid from vm_images_view Line 590: JOIN vm_device ON vm_device.device_id = vm_images_view.disk_id Line 591: where v_storage_domain_id in (SELECT * FROM fnsplitteruuid(storage_id))); amend how? Line 592: delete FROM images where image_guid in (select image_guid from tt_TEMPSTORAGEDOMAINMAPTABLE); Line 593: delete FROM permissions where object_id in (select image_group_id from tt_TEMPSTORAGEDOMAINMAPTABLE); Line 594: delete FROM vm_interface where vmt_guid in(select vm_guid from TEMPLATES_IDS_TEMPORARY_TABLE); Line 595: delete FROM permissions where object_id in (select vm_guid from TEMPLATES_IDS_TEMPORARY_TABLE); Line 589: delete FROM snapshots WHERE vm_id in (select vm_id as vm_guid from vm_images_view Line 590: JOIN vm_device ON vm_device.device_id = vm_images_view.disk_id Line 591: where v_storage_domain_id in (SELECT * FROM fnsplitteruuid(storage_id))); Line 592: delete FROM images where image_guid in (select image_guid from tt_TEMPSTORAGEDOMAINMAPTABLE); Line 593: delete FROM permissions where object_id in (select image_group_id from tt_TEMPSTORAGEDOMAINMAPTABLE); so I guess there's a similar problem on line 595 (templates with disks on multiple domains?) Line 594: delete FROM vm_interface where vmt_guid in(select vm_guid from TEMPLATES_IDS_TEMPORARY_TABLE); Line 595: delete FROM permissions where object_id in (select vm_guid from TEMPLATES_IDS_TEMPORARY_TABLE); Line 596: delete FROM permissions where object_id = v_storage_domain_id; Line 597: delete FROM vm_static where vm_guid in(select vm_id as vm_guid from vm_images_view -- To view, visit http://gerrit.ovirt.org/11737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6db8694858bca7ddbe8579931279cb77d741f58b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
