Tal Nisan has posted comments on this change.
Change subject: webadmin: attach disk dialog - no selection validation
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
Minor comment
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
Line 1712: String confirmConsoleConnect();
Line 1713:
Line 1714: @DefaultStringValue("There may be users connected to the console
who will not be able to reconnect. Do you want to proceed?")
Line 1715: String confirmConsoleConnectMessage();
Line 1716:
Is that a whitespace? If so remove it please
Line 1717: @DefaultStringValue("No disks selected")
Line 1718: String noDisksSelected();
--
To view, visit http://gerrit.ovirt.org/11822
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17bbe414323ee81723809f5de4434406fa37cf69
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
