Vojtech Szocs has posted comments on this change. Change subject: [WIP] webadmin: UI plugin dialog API improved ......................................................................
Patch Set 1: Thanks guys for the review! As for the optional arguments object, we can support following optional arguments: - buttons [default empty]: custom buttons in bottom-right corner of the dialog [label, onClick] - resizeEnabled [default false]: whether to allow dialog resizing with mouse - closeIconVisible [default false]: whether to show red 'X' close icon in top-right corner of the dialog - closeOnEscKey [default false]: whether to close the dialog when user presses ESC key Note: all standard WebAdmin dialogs have closeIconVisible=true and closeOnEscKey=true -- To view, visit http://gerrit.ovirt.org/11717 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4654a25bed7122c45d432e3860ed710fa4ca3dd9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Chris Morrissey <cmorr...@netapp.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Spenser Shumaker <sshum...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
