Juan Hernandez has posted comments on this change.

Change subject: WIP: working CDI solution for backend
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/interfaces/BackendInternal.java
Line 77:      */
Line 78:     ArrayList<VdcReturnValueBase> 
runInternalMultipleActions(VdcActionType actionType,
Line 79:             ArrayList<VdcActionParametersBase> parameters,
Line 80:             ExecutionContext executionContext);
Line 81: 
The DfFacade is injected into CommandBase, and it can't be created just with 
its constructor, as it would not have the dialect and the JDBC template it 
needs, the creation has to go trough the Backend, which will call the 
DbFacadeLocator. So the Backend is acting as the factory for DbFacade, thus the 
@Produces annotation.
Line 82:     DbFacade getDbFacade();
Line 83: 


--
To view, visit http://gerrit.ovirt.org/5575
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f604ff91847b698efe84a09f724ba0492a672c1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to