Allon Mureinik has posted comments on this change. Change subject: core: Use storage validator when validating move or copy. ......................................................................
Patch Set 5: Looks good to me, but someone else must approve (1 inline comment) missing modifier, please fix. Other than that - +2. .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java Line 48: Line 49: private final Guid diskImageGuid = Guid.NewGuid(); Line 50: private Guid destStorageId = Guid.NewGuid(); Line 51: private final Guid srcStorageId = Guid.NewGuid(); Line 52: private static int FREE_SPACE_CRITICAL_LOW_IN_GB = 0; should be final Line 53: Line 54: @ClassRule Line 55: public static MockConfigRule mcr = new MockConfigRule( Line 56: mockConfig(ConfigValues.FreeSpaceCriticalLowInGB, FREE_SPACE_CRITICAL_LOW_IN_GB)); -- To view, visit http://gerrit.ovirt.org/11513 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01980de86ed445d397f12ff9c471974d1cb5c44d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
