Michael Pasternak has posted comments on this change.
Change subject: restapi : vm/template Import candidates should have /disks
(#829672)
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
two tiny reuse comments, + please add collections tests,
besides these, looks good.
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendExportDomainTemplateDisksResource.java
Line 3: import java.util.Collections;
Line 4: import java.util.Set;
Line 5: import org.ovirt.engine.core.compat.Guid;
Line 6:
Line 7: public class BackendExportDomainTemplateDisksResource extends
BackendExportDomainDisksResource {
ravi, this class completely redundant, you can solve this by reusing
BackendExportDomainDisksResource via generic parameters
Line 8:
Line 9: private final BackendStorageDomainTemplateResource parent;
Line 10: private org.ovirt.engine.core.common.businessentities.VmTemplate
template;
Line 11:
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendExportDomainVmDisksResource.java
Line 3: import java.util.Collections;
Line 4: import java.util.Set;
Line 5: import org.ovirt.engine.core.compat.Guid;
Line 6:
Line 7: public class BackendExportDomainVmDisksResource extends
BackendExportDomainDisksResource {
ravi, this class completely redundant, you can solve this by reusing
BackendExportDomainDisksResource via generic parameters
Line 8:
Line 9: private final BackendStorageDomainVmResource parent;
Line 10: private org.ovirt.engine.core.common.businessentities.VM vm;
Line 11:
--
To view, visit http://gerrit.ovirt.org/11126
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I83fd4b046f72f73bb516615137522ac40028a7f0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
