Itamar Heim has posted comments on this change.
Change subject: core: Eliminated use of StringHelper.EqOp
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/AdUserConditionFieldAutoCompleter.java
Line 15: // building the ColumnName Dict
Line 16: columnNameDict.put("NAME", "$GIVENNAME");
Line 17: columnNameDict.put("USERNAME", "$SAMACCOUNTNAME");
Line 18:
Line 19: if
("LDAP".equalsIgnoreCase(SyntaxCheckerFactory.getConfigAuthenticationMethod()))
{
i don't think we have more than LDAP today (used to have LOCAL), but since we
are just about to add back non LDAP, i actually prefer this to stay
Line 20: mVerbs.put("LASTNAME", "LASTNAME");
Line 21: mVerbs.put("DEPARTMENT", "DEPARTMENT");
Line 22: mVerbs.put("TITLE", "TITLE");
Line 23:
....................................................
Commit Message
Line 6:
Line 7: core: Eliminated use of StringHelper.EqOp
Line 8:
Line 9: Removed the method StringHelper.EqOp, it was used mainly in
searchbackend
Line 10: module to check String equality with constancts thus it could be
replaced
s/constancts/constants/
Line 11: with standard String implementation of equals and equalsIgnoreCase
Line 12:
Line 13: Change-Id: Iaf3d65db824f31df05dc7b0eda5f9c24274cf53c
--
To view, visit http://gerrit.ovirt.org/11670
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf3d65db824f31df05dc7b0eda5f9c24274cf53c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
