Juan Hernandez has posted comments on this change. Change subject: tools: Consolidate all tools to single project ......................................................................
Patch Set 1: (1 inline comment) .................................................... File pom.xml Line 198: <groupId>commons-lang</groupId> Line 199: <artifactId>commons-lang</artifactId> Line 200: <version>${commons-lang.version}</version> Line 201: </dependency> Line 202: <dependency> We probably don't need to add it here, but I think is good practice to have dependencies used frequently in the dependenciesManagement section, that way we don't need to specify the version every time that we use that dependency in a subproject. I can remove this if you don't want it. Line 203: <groupId>commons-configuration</groupId> Line 204: <artifactId>commons-configuration</artifactId> Line 205: <version>${commons-configuration.version}</version> Line 206: </dependency> -- To view, visit http://gerrit.ovirt.org/11558 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id93001dd30afd9a8d5a10a122c21a17fd3c67aa2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches