Liron Aravot has posted comments on this change. Change subject: core: handle error when iso domain in maintenance ......................................................................
Patch Set 6: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java Line 293: if (status != StorageDomainStatus.Active) { Line 294: log.debugFormat("Storage domain id {0}, is not active, and therefore could not be refreshed for {1} file type (Iso domain status is {2}).", Line 295: storageDomainId, Line 296: fileTypeExt, Line 297: status); If we already print it, I'd consider (in a different patch, unrelated to this change) to add storage pool to this message. Line 298: } Line 299: else { Line 300: // Try to refresh the domain of the storage pool id because its status is active. Line 301: refreshSucceeded = -- To view, visit http://gerrit.ovirt.org/11449 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide53f42c087ffbc9240cccc033e809ff8117ec8c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches