Allon Mureinik has posted comments on this change.
Change subject: core: RemoveStorageDomainTest: simply msg checking
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainTest.java
Line 82: RemoveStorageDomainCommand<RemoveStorageDomainParameters> cmd
= createCommand(true);
Line 83: assertTrue(cmd.canDoAction());
Line 84:
Line 85: checkSucceeded(cmd, false);
Line 86: checkMessages(cmd);
The ellipsis (...) operator translates no-args into a zero length array, which
is exactly the behaviour I want here - zero messages.
(Note also that this patch is marked as verified, so it should mean I've
checked it and it actually works :-))
Line 87: }
Line 88:
Line 89: @Test
Line 90: public void testSetActionMessageParameters() {
....................................................
Commit Message
Line 3: AuthorDate: 2013-01-15 03:03:21 +0200
Line 4: Commit: Allon Mureinik <amure...@redhat.com>
Line 5: CommitDate: 2013-02-01 00:03:34 +0200
Line 6:
Line 7: core: RemoveStorageDomainTest: simply msg checking
yes, will fix,
Line 8:
Line 9: Simplified the way canDoAction messages are asserted in the test.
Line 10:
Line 11: Change-Id: I134240763353c88d14948bea535e362c3db42fd1
--
To view, visit http://gerrit.ovirt.org/11607
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I134240763353c88d14948bea535e362c3db42fd1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
