Alissa Bonas has posted comments on this change. Change subject: core: Remove StringHelper from vdsbroker package ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) just see my comment regarding patch title .................................................... Commit Message Line 3: AuthorDate: 2013-01-31 20:32:53 +0200 Line 4: Commit: Allon Mureinik <amure...@redhat.com> Line 5: CommitDate: 2013-02-01 00:36:02 +0200 Line 6: Line 7: core: Remove StringHelper from vdsbroker package It's a misleading title - I understood from it that the class StringHelper is removed in this patch. I'd consider changing it to replace usage of StringHelper/remove usages of StringHelper Line 8: Line 9: Remove the last leftovers of the deprecated StringHelper usages from the Line 10: vdsbroker package and replace them with apache's standard StringUtils. Line 11: -- To view, visit http://gerrit.ovirt.org/11608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a0bffa6712fe38b5985d92c6860af37c54985c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel P. Berrange <berra...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches