Juan Hernandez has posted comments on this change.
Change subject: pki: process template files not in-place
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File packaging/fedora/spec/ovirt-engine.spec.in
Line 675:
Line 676: # PKI configuration files:
Line 677: %config(noreplace) %{engine_pki}/openssl.conf
Line 678: %config(noreplace) %{engine_pki}/cacert.template.in
Line 679: %config(noreplace) %{engine_pki}/cert.template.in
You are right about the .in files, they replace completely the .template files
as configuration. It is the cert.conf file (and maybe also cacert.conf) that
should be marked as configuration, and the .in and .template files should be
moved out of /etc, but that is probably for another patch.
The .p12, .pem, and .pgpass files should also be marked as configuration files,
to the extent possible, for those that we know the complete name in advance.
Line 680:
Line 681: # The certificate database files:
Line 682: %config(noreplace) %attr(-, %{engine_user}, %{engine_group})
%{engine_pki}/database.txt
Line 683: %config(noreplace) %attr(-, %{engine_user}, %{engine_group})
%{engine_pki}/serial.txt
--
To view, visit http://gerrit.ovirt.org/11577
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaba7b66633eb92b0b6602fb17218d5e844256dd3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
