Juan Hernandez has posted comments on this change.

Change subject: pki: install private directories not world readable
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File packaging/fedora/spec/ovirt-engine.spec.in
Line 671: # create files inside:
Line 672: %dir %attr(-, %{engine_user}, %{engine_group}) %{engine_pki}
Line 673: %dir %attr(-, %{engine_user}, %{engine_group}) %{engine_pki}/certs
Line 674: %dir %attr(0750, %{engine_user}, %{engine_group}) %{engine_pki}/keys
Line 675: %dir %attr(0750, %{engine_user}, %{engine_group}) 
%{engine_pki}/private
This is not needed as the directories already have this permission in the 
Makefile.
Line 676: %dir %attr(-, %{engine_user}, %{engine_group}) %{engine_pki}/requests
Line 677: 
Line 678: # PKI scripts:
Line 679: %{engine_pki}/*.sh


--
To view, visit http://gerrit.ovirt.org/11578
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9928cff3f16633e2bea8064b6ee9672f5043fab0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to