Arik Hadas has uploaded a new change for review. Change subject: core: prevent changing display type when vm isn't down ......................................................................
core: prevent changing display type when vm isn't down This patch adds display protocol to the group of vm properties that can be updated only when the vm is in down state, in order to prevent scanario in which the user change it while the vm is in hibernate mode and he expects the display type to be updated when the vm is restored from hibernation. Change-Id: I7b1676e8e0d69fa6579d3b2323d1372e2e55c4ef Bug-Url: https://bugzilla.redhat.com/877938 Signed-off-by: Arik Hadas <aha...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/37/11537/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java index 8a88b9b..0db2150 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java @@ -81,7 +81,7 @@ mUpdateVmsStatic.AddPermittedFields(new String[] { "vmName", "description", "domain", "os", "osType", "creationDate", "numOfMonitors", "allowConsoleReconnect", "usbPolicy", "autoSuspend", "autoStartup", - "dedicatedVmForVds", "defaultDisplayType", "priority", "defaultBootSequence", "initrdUrl", + "dedicatedVmForVds", "priority", "defaultBootSequence", "initrdUrl", "kernelUrl", "kernelParams", "migrationSupport", "minAllocatedMem", "quotaId", "quotaName", "quotaEnforcementType", "cpuPinning", "vmPayload", "balloonEnabled", "smartcardEnabled","deleteProtected","dbGeneration", @@ -94,7 +94,7 @@ Arrays.asList(new Enum<?>[] { VMStatus.Down }), Arrays.asList(new String[] { "vdsGroupId", "timeZone", "stateless", "niceLevel", "memSizeMb", "numOfSockets", "cpuPerSocket", "isoPath", "userDefinedProperties", - "predefinedProperties", "customProperties" })); + "predefinedProperties", "customProperties", "defaultDisplayType" })); } public static boolean IsUpdateValid(VmStatic source, VmStatic destination, VMStatus status) { -- To view, visit http://gerrit.ovirt.org/11537 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7b1676e8e0d69fa6579d3b2323d1372e2e55c4ef Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
