Greg Padgett has posted comments on this change. Change subject: core:DB upgrade from 3.0 to 3.1 fails ......................................................................
Patch Set 2: Just saw this, I know it's a bit late now but just for similar scenarios in the future: there is a small chance that using ILIKE can cause issues because it treats _ and % in the pattern as wildcards. For simple case-insensitive comparisons that don't need wildcards, I'd prefer to see "lower(strA) = lower(strB)". To make ILIKE safe against unknown strings you'd need to escape both the escape char and the wildcards: strA ILIKE REPLACE(REPLACE(REPLACE(strB, '|', '||'), '_', '|_'), '%', '|%') ESCAPE '|'; -- To view, visit http://gerrit.ovirt.org/11419 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id36c83154559d6062609d08068989d3ce3d2c468 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
