Juan Hernandez has posted comments on this change.
Change subject: packaging: suggest path for local storage during AIO setup
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File packaging/fedora/setup/plugins/all_in_one_100.py
Line 87:
controller.getParamByName("CONFIG_NFS").setKey("DEFAULT_VALUE", "yes")
Line 88: return True
Line 89:
Line 90:
Line 91: def generateLocalStorageDomainName():
Isn't this name a bit misleading? I mean, this doesn't build the name of the
storage domain, but the path.
Line 92: '''
Line 93: Generates name for local storage domain
Line 94: '''
Line 95: if os.path.exists(LOCAL_STORAGE_PATH):
--
To view, visit http://gerrit.ovirt.org/11392
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb131c3e8d88d6503dc2a03d46fa86590ead52cb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
