Eli Mesika has posted comments on this change.
Change subject: engine: Fixed sorting VMs by IP address in search
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java
Line 315: String ipPattern =
Line 316:
"^(?:(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\\.){3}(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)$";
Line 317: for (String ipAddress : separateIpAddresses) {
Line 318: if (!Regex.IsMatch(ipAddress, ipPattern)) {
Line 319: value.argvalue = null;
I would expect that if you have a string that does not match the IP pattern it
will be at least logged and not skipped as you suggest here ...
Line 320: return;
Line 321: }
Line 322: }
Line 323:
--
To view, visit http://gerrit.ovirt.org/11433
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1230544796692845a8b32a5e020880fde0c32740
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
