Moti Asayag has posted comments on this change.
Change subject: core: fix monitoring of SetNonOperationalVdsCommand
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java
Line 222: * Indicates if the current command was executed under
a correlation-ID
Line 223: * @return true if the command should be monitored, else false.
Line 224: */
Line 225: private static boolean shouldMonitorCommand(VdcActionType
actionType, boolean isInternal, boolean hasCorrelationId, VdcActionType
parentActionType) {
Line 226: if (actionType == VdcActionType.InternalMigrateVm &&
parentActionType == VdcActionType.SetNonOperationalVds)
I don't like introducing a specific logic into a generic method.
Why not using ExecutionHandler.createInternalJobContext() from the specific
flow of SetNonOperationalVds that creates InternalMigrateVm commands ?
Line 227: return true;
Line 228: else
Line 229: return (actionType.isActionMonitored() ||
hasCorrelationId) && !isInternal;
Line 230: }
--
To view, visit http://gerrit.ovirt.org/11370
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I06b08108b1c75fe00b3f4dc6336c61a5e8c95d85
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
