Allon Mureinik has posted comments on this change.
Change subject: core: TryBackToAllSnapshots- use filtered disks
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java
Line 212: &&
validate(snapshotsValidator.snapshotExists(snapshot))
Line 213: &&
validate(snapshotsValidator.snapshotNotBroken(snapshot));
Line 214:
Line 215: Collection<DiskImage> diskImages =
Line 216:
ImagesHandler.filterImageDisks(getVm().getDiskMap().values(), false, true);
1. Good catch! this was a subtle bug in the original command too - the
(false,true) above is (asumably) correct for the commands business logic. The
fact that inside we're also checking other disks - well, fail.
2. Good catch again, will fix.
Line 217: if (!diskImages.isEmpty()) {
Line 218: result =
Line 219: result
Line 220: && validate(new
StoragePoolValidator(getStoragePool()).isUp())
--
To view, visit http://gerrit.ovirt.org/11447
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18edb75723b7f6019864e0fcabde49bdb26b53f1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
