Tal Nisan has posted comments on this change.
Change subject: core: storage domain validation refactoring
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmTemplateCommand.java
Line 87: if (getVmTemplate() != null) {
Line 88: setDescription(getVmTemplateName());
Line 89: }
Line 90: StorageDomainValidator storageDomainValidator = new
StorageDomainValidator(getStorageDomain());
Line 91: boolean retVal =
validate(storageDomainValidator.isDomainExistAndActive());
You can just return false here if it's not validated
Line 92:
Line 93: if (retVal) {
Line 94: // export must be to export domain
Line 95: if (getStorageDomain().getstorage_domain_type() !=
StorageDomainType.ImportExport) {
--
To view, visit http://gerrit.ovirt.org/11415
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I64734303de8c9cfaaca4fba6bfeeccc93e18c9a6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
