Liron Aravot has posted comments on this change.
Change subject: core: ImagesHandler.checkDiskImages with multi-SDs
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 522: if (!Guid.Empty.equals(storageDomainId)) {
Line 523: domainsIds.add(storageDomainId);
Line 524: } else {
Line 525: for (DiskImage image : images) {
Line 526: domainsIds.addAll(image.getstorage_ids());
not sure, why would we want to check an previous image domain threshold? (line
540)
Line 527: }
Line 528: }
Line 529: for (Guid domainId : domainsIds) {
Line 530: storage_domains domain =
DbFacade.getInstance().getStorageDomainDao().getForStoragePool(
--
To view, visit http://gerrit.ovirt.org/11414
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61b729bdcbd3001d371fb58a6358172b07be94f4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
