Michael Kublin has posted comments on this change. Change subject: core: AddVdsSpmId - execute for a number of VDSs at once. ......................................................................
Patch Set 3: I would prefer that you didn't submit this Liron, Sorry that I wrote these but I did not understood your code (I need to read it 4 times !!!), it is unreadable. The following improvement is useless and waste of time, a change should be much deeper, it should contain remove of global transaction, fixing possible race and improving locks. The change should be done in one patch. -- To view, visit http://gerrit.ovirt.org/11412 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ecf9990eeda676ad2a4f9bd73d4535bd2eb3f9a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
