Doron Fediuck has posted comments on this change. Change subject: engine-config: Adding man page ......................................................................
Patch Set 2: I would prefer that you didn't submit this Douglas, I see 2 issues here need to be handled; 1. Please remove the bz url in the commit message, which has limited visibility. 2. The man page should include usage of the utility, but not the keys' description, which is given when listing the keys. This also creates data duplication as each modification of the keys should be handled here as well, and this is not desirable. -- To view, visit http://gerrit.ovirt.org/11176 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I546d90550ddf53707bc667c18e8c0d44e909593f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
