Sandro Bonazzola has posted comments on this change. Change subject: packaging: checking SELINUX status during ports redirection ......................................................................
Patch Set 4: I would prefer that you didn't submit this utils.execCmd(cmdList=cmd, failOnError=True) in engine_validators.py:218 will never be executed because it's after a return statement. Maybe you forgot to remove the line. The comment says "and exit if user doesn't want to." but the script exits anyway if selinux is disabled. EXEC_SETENFORCE and INFO_ASK_ENABLE_SELINIX are not used anymore, you can remove them. -- To view, visit http://gerrit.ovirt.org/11345 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e9f4c1abc8c58a1b1556ba56f4cc0acfac91050 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
